[Bug 787466] glimagesink: release buffers on GST_EVENT_FLUSH_START

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787466

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |INVALID

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Yuji Kuwabara from comment #3)
> https://gstreamer.freedesktop.org/documentation/design/events.html
> 
> "... discards any buffers it is holding ..."
> 
> -----------------------------------------------
> Flushing happens in two stages.
> 
> a source element sends the FLUSH_START event to the downstream peer element.
> The downstream element starts rejecting buffers from the upstream elements.
> It sends the flush event further downstream and discards any buffers it is
> holding as well as return from the chain function as soon as possible. This
> makes sure that all upstream elements get unblocked. This event is not
> synchronized with the STREAM_LOCK and can be done in the application thread.
> -----------------------------------------------

The documentation is maybe not clear, but the referred buffers are the
in-flight buffer. E.g. a buffer being pushed will be discarded immediately. The
other buffers are part of the state.

Specifically to glimagesink, these buffer may be used through other interface,
and you cannot just get rid of them without causing side effect.

I think this bug is a pretty bad start, so I'll close it now. If you do
encountered a bug, and if this patch fixes a bug for you, please file a new
issue and describe the issue. We will guide you on how this can be fixed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.