[Bug 786739] appsink: handle drain query

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786739

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358707|none                        |needs-work
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 358707:
 --> (https://bugzilla.gnome.org/review?bug=786739&attachment=358707)

Looks good, but I would like not to see yet another racy test using g_usleep().
There is so many tests to fix, let's not add more.

::: tests/check/elements/appsink.c
@@ +535,3 @@
+  GstSample *pulled_sample = NULL;
+
+  g_usleep (1 * G_USEC_PER_SEC);

Would be nice to avoid g_usleep(), it makes the tests slow and racy.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.