[Bug 785471] [API]: gst_audio_channel_mixer_new_with_matrix

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785471

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357581|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 357581:
 --> (https://bugzilla.gnome.org/review?bug=785471&attachment=357581)

::: gst/audioconvert/gstaudioconvert.c
@@ +198,3 @@
+          "Transformation matrix for input/output channels",
+          gst_param_spec_array ("matrix-in1", "rows", "rows",
+              g_param_spec_float ("matrix-in2", "cols", "cols",

matrix-rows and matrix-cols instead of matrix-in* maybe

@@ +303,3 @@
+   * or if a mix matrix was manually specified */
+  if (G_IS_VALUE (&this->mix_matrix) ||
+      !gst_structure_get (s, "channel-mask", GST_TYPE_BITMASK, &mask, NULL) ||

If a matrix was manually specified, we can only support N input and M output
channels, or not? By removing the channels field, you allow any number of
channels.
But the channel-mask should disappear

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.