[Bug 785471] [API]: gst_audio_channel_mixer_new_with_matrix

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785471

--- Comment #13 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #12)
> Review of attachment 357581 [details] [review]:
> 
> ::: gst/audioconvert/gstaudioconvert.c
> @@ +198,3 @@
> +          "Transformation matrix for input/output channels",
> +          gst_param_spec_array ("matrix-in1", "rows", "rows",
> +              g_param_spec_float ("matrix-in2", "cols", "cols",
> 
> matrix-rows and matrix-cols instead of matrix-in* maybe

Sure, done

> 
> @@ +303,3 @@
> +   * or if a mix matrix was manually specified */
> +  if (G_IS_VALUE (&this->mix_matrix) ||
> +      !gst_structure_get (s, "channel-mask", GST_TYPE_BITMASK, &mask, NULL)
> ||
> 
> If a matrix was manually specified, we can only support N input and M output
> channels, or not? By removing the channels field, you allow any number of
> channels.
> But the channel-mask should disappear

In case a matrix is specified and its dimensions do not match the input /
output channels, we fail negotiation:

gst-launch-1.0 audiotestsrc ! audio/x-raw ! audioconvert
mix-matrix="<<(float)1.0, (float)0.0, (float)0.0, (float)0.0>, <(float)0.0,
(float)0.0, (float)0.0, (float)0.0>>" ! audio/x-raw,channels=2 ! autoaudiosink

0:00:00.021796138 23185      0x24f00f0 ERROR        audio-converter
audio-converter.c:650:check_mix_matrix: Invalid mix matrix row size, should be
2
0:00:00.021823146 23185      0x24f00f0 ERROR           audioconvert
gstaudioconvert.c:738:gst_audio_convert_set_caps:<audioconvert0> could not make
converter
[..]
ERROR: from element /GstPipeline:pipeline0/GstAudioTestSrc:audiotestsrc0:
Internal data stream error.
[..]
streaming stopped, reason not-negotiated (-4)

Is it not good enough?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.