[Bug 786344] audioaggregator: implement input conversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786344

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Mathieu Duponchelle from comment #3)
> (In reply to Olivier Crête from comment #2)
> > Review of attachment 357684 [details] [review] [review]:
> > 
> > Generally looks like a good first step!
> > 
> > ::: gst-libs/gst/audio/gstaudioaggregator.c
> > @@ +300,3 @@
> > +G_DEFINE_ABSTRACT_TYPE_WITH_CODE (GstAudioAggregator, gst_audio_aggregator,
> > +    GST_TYPE_AGGREGATOR, g_type_add_class_private (g_define_type_id,
> > +        sizeof (GstAudioAggregatorClassPrivate)));
> > 
> > Any reason not to use G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE ?
> > 
> 
> It's a *class* private, no macros for that :)

Thanks for being the first user (I'm aware of) of this feature. I added that to
GObject ages ago, but before it was merged we broke GStreamer API and I didn't
need it anymore ;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.