[Bug 786344] audioaggregator: implement input conversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786344

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #360227|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 360227:
 --> (https://bugzilla.gnome.org/review?bug=786344&attachment=360227)

::: gst-libs/gst/audio/gstaudioaggregator.c
@@ +57,3 @@
+    GST_PAD_SINK,
+    GST_PAD_REQUEST,
+    SINK_CAPS);

Subclasses might want to limit the caps in one way or another. E.g. only allow
mono inputs.

@@ +135,3 @@
+      if (pad->priv->converter_config)
+        g_value_take_boxed (value,
+            gst_structure_copy (pad->priv->converter_config));

Or just g_value_set_boxed(value, config)? That copies internally then. Less
noise

@@ +592,3 @@
+  /* TODO: handle different rates on sinkpads, a bit complex
+   * because offsets will have to be updated, and audio resampling
+   * has a latency to take into account

You should prevent that in get_caps() then if it's not supported yet (ignoring
the race condition between getcaps and setcaps).

::: gst-libs/gst/audio/gstaudioaggregator.h
@@ +168,3 @@

+GST_EXPORT
+void gst_audio_aggregator_class_perform_conversion (GstAudioAggregatorClass *
klass);

Should probably take a boolean so sub-subclasses can override it, and maybe a
vfunc that does the conversion and can be overridden?

::: gst/audiomixer/gstaudiomixer.h
@@ -53,3 @@
-
-  /* target caps (set via property) */
-  GstCaps *filter_caps;

\o/ It's gone finally

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.