[Bug 794794] rtpssrcdemux: add the support of buffer list

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794794

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370342|none                        |needs-work
             status|                            |

--- Comment #10 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 370342:
 --> (https://bugzilla.gnome.org/review?bug=794794&attachment=370342)

Can you also squash all the patches, it's really hard to work with fixup
patches with bugzilla.

::: gst/rtpmanager/gstrtpssrcdemux.c
@@ +183,1 @@
+      gst_buffer_list_add (demuxpad->buffer_list, buf);

This takes a reference on buf.

@@ +207,3 @@
+      GST_WARNING_OBJECT (demux, "failing to push data on ssrc %08x src pad",
+          demuxpad->ssrc);
+      return GST_FLOW_ERROR;

That's probably GST_FLOW_FLUSHING if the pad is not active. If you were to
return GST_FLOW_ERROR, you also want to post a message on the bus with
GST_ELEMENT_ERROR()

@@ +737,3 @@

+  if (!gst_buffer_list_foreach (buf_list, process_buffer_list_item, demux))
+    return GST_FLOW_ERROR;

If you really want to return GST_FLOW_ERROR, you need to post an error on the
bus, but I don't think you want to do that here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.