[Bug 794794] rtpssrcdemux: add the support of buffer list

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794794

--- Comment #11 from Eloi BAIL <eloi.bail at savoirfairelinux.com> ---
Review of attachment 370342:
 --> (https://bugzilla.gnome.org/review?bug=794794&attachment=370342)

Sure, I will squash all my changes.

::: gst/rtpmanager/gstrtpssrcdemux.c
@@ +183,1 @@
+      gst_buffer_list_add (demuxpad->buffer_list, buf);

Ok it is not so clear to me. If I remove gst_buffer_ref, I need also to remove
the call to gst_buffer_list_unref.
Otherwise, I see lots of "GStreamer-CRITICAL **: gst_mini_object_unref:
assertion 'GST_MINI_OBJECT_REFCOUNT_VALUE (mini_object) > 0' failed" error
messages.

@@ +207,3 @@
+      GST_WARNING_OBJECT (demux, "failing to push data on ssrc %08x src pad",
+          demuxpad->ssrc);
+      return GST_FLOW_ERROR;

ok I will return GST_FLOW_FLUSHING

@@ +737,3 @@

+  if (!gst_buffer_list_foreach (buf_list, process_buffer_list_item, demux))
+    return GST_FLOW_ERROR;

ok according to other elements, this case is never handled. I would then ignore
the return value

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.