[Bug 794966] rtsp-stream: avoid deadlock when playing a media where some streams are inactive

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794966

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370516|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 370516:
 --> (https://bugzilla.gnome.org/review?bug=794966&attachment=370516)

::: gst/rtsp-server/rtsp-media.c
@@ +4385,2 @@
+    /* a stream transport is connected to a stream from it's creation to it's
+     * destruction and thus it must be possible to obtain "it's" stream while

its not it's :)

::: gst/rtsp-server/rtsp-stream.c
@@ +4686,3 @@
+  g_mutex_lock (&priv->lock);
+  if (!priv->is_complete) {
+    priv->drop_buffers = TRUE;

This seems a bit unintuitive. If setting it to dropping it should probably
always do that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.