[Bug 795117] jpegparse: Fix the code to handle APP1 marker segment skipping

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795117

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370715|none                        |reviewed
             status|                            |

--- Comment #2 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 370715:
 --> (https://bugzilla.gnome.org/review?bug=795117&attachment=370715)

::: gst/jpegformat/gstjpegparse.c
@@ +575,3 @@
+    /* restore the byte position and size */
+    reader->size += 2;
+    reader->byte -= 2;

rather than modify the internal state of the reader why not just skip the
reported marker size, something like

    GST_DEBUG_OBJECT (parse, "unhandled marker %x skiping %u bytes", APP1,
        size);
    if (!gst_byte_reader_skip (reader, size))
      return FALSE;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.