[Bug 795117] jpegparse: Fix the code to handle APP1 marker segment skipping

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795117

--- Comment #3 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #2)
> Review of attachment 370715 [details] [review]:
> 
> ::: gst/jpegformat/gstjpegparse.c
> @@ +575,3 @@
> +    /* restore the byte position and size */
> +    reader->size += 2;
> +    reader->byte -= 2;
> 
> rather than modify the internal state of the reader why not just skip the
> reported marker size, something like
> 
>     GST_DEBUG_OBJECT (parse, "unhandled marker %x skiping %u bytes", APP1,
>         size);
>     if (!gst_byte_reader_skip (reader, size))
>       return FALSE;

No, it won't work, the immediate call to
gst_jpeg_parse_skip_marker() has to retrieve the size of the header from the
first two bytes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.