[Bug 793705] msdk: Implement Video Post Processing element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793705

--- Comment #36 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 370068:
 --> (https://bugzilla.gnome.org/review?bug=793705&attachment=370068)

::: sys/msdk/gstmsdkvpp.c
@@ +315,3 @@
+    pool =
+        gst_msdkvpp_create_buffer_pool (thiz, GST_PAD_SRC, caps, min_buffers);
+    thiz->srcpad_buffer_pool = pool;

I meant the assignation of thiz->srcpad_buffer_pool

What if downstream offers a proper bufferpool, thus it is not required to be
created, and thiz->srcpad_buffer_pool is not set

@@ +381,3 @@
+  }
+
+  pool = thiz->sinkpad_buffer_pool;

here's a long explanation: https://bugzilla.gnome.org/show_bug.cgi?id=748344

long story short: Caching pools makes certain renegotiation scenario fails.
Create a new pool for each propose_allocation() call here. Allocator can be
reused without problems.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.