[Bug 793705] msdk: Implement Video Post Processing element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793705

--- Comment #37 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #36)
> Review of attachment 370068 [details] [review]:
> 
> ::: sys/msdk/gstmsdkvpp.c
> @@ +315,3 @@
> +    pool =
> +        gst_msdkvpp_create_buffer_pool (thiz, GST_PAD_SRC, caps,
> min_buffers);
> +    thiz->srcpad_buffer_pool = pool;
> 
> I meant the assignation of thiz->srcpad_buffer_pool
> 
> What if downstream offers a proper bufferpool, thus it is not required to be
> created, and thiz->srcpad_buffer_pool is not set

Yup right!
BTW, I think each msdk element should always create its own bufferpool in
decide_allocation. Each of the MSDK components has to allocate resources
(mfxSurfaces)separately even though we share the context. Which means each msdk
element create a new pool in decide_allocation irrespective of what downstream
provides.
The unnecessary copy can be avoided in each element by checking whether the
buffer is originated from a msdk pool.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.