[Bug 795157] API: gst_queue_array_peek_nth

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Apr 11 13:58:17 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795157

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #370792|none                        |needs-work
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 370792
  --> https://bugzilla.gnome.org/attachment.cgi?id=370792
API: gst_queue_array_peek_nth

Looks good to me. Small nitpicks:

- Function docs should perhaps also explicitly mention that the caller must
check that the idx is valid, we don't handle out of bounds index access
gracefully (but maybe we just should? Dunno.)

- run make update-exports to add the new API also to
win32/common/libgstbase.def (while it still exists)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list