[Bug 795157] API: gst_queue_array_peek_nth

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Apr 11 19:04:17 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795157

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Tim-Philipp Müller from comment #2)
> Comment on attachment 370792 [details] [review]
> API: gst_queue_array_peek_nth
> 
> Looks good to me. Small nitpicks:
> 
> - Function docs should perhaps also explicitly mention that the caller must
> check that the idx is valid, we don't handle out of bounds index access
> gracefully (but maybe we just should? Dunno.)

g_return_val_if_fail() please

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list