[Bug 795260] debug-viewer: port to Python3

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795260

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370930|none                        |accepted-commit_now
             status|                            |

--- Comment #6 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 370930:
 --> (https://bugzilla.gnome.org/review?bug=795260&attachment=370930)

Apart from those "insignificant" points this looks good. Looks like you removed
some unit tests but better have less tests but have them working than have
broken tests fmpov!

Just fix that small remark and push I would say!

(Also I tested and it seems to work properly here :-))

::: debug-viewer/GstDebugViewer/Data.py
@@ -148,3 +149,3 @@
     LEVEL = "([A-Z]+)\s+"
     # "0x8165430 "
-    THREAD = r"(0x[0-9a-f]+)\s+"  # r"\((0x[0-9a-f]+) - "
+    THREAD = "(0x[0-9a-f]+)\s+"  # r"\((0x[0-9a-f]+) - "

Why did you remove the leading `r` heard, those are all regex and it is better
to mark that.

::: debug-viewer/GstDebugViewer/Main.py
@@ +37,1 @@
     from GstDebugViewer import version

We should use same versionning as GStreamer here fmpov :-)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.