[Bug 795260] debug-viewer: port to Python3

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795260

--- Comment #7 from Philippe Normand <philn at igalia.com> ---
(In reply to Thibault Saunier from comment #6)
> Review of attachment 370930 [details] [review]:
> 
> Apart from those "insignificant" points this looks good. Looks like you
> removed some unit tests but better have less tests but have them working
> than have broken tests fmpov!
> 
> Just fix that small remark and push I would say!
> 
> (Also I tested and it seems to work properly here :-))
> 
> ::: debug-viewer/GstDebugViewer/Data.py
> @@ -148,3 +149,3 @@
>      LEVEL = "([A-Z]+)\s+"
>      # "0x8165430 "
> -    THREAD = r"(0x[0-9a-f]+)\s+"  # r"\((0x[0-9a-f]+) - "
> +    THREAD = "(0x[0-9a-f]+)\s+"  # r"\((0x[0-9a-f]+) - "
> 
> Why did you remove the leading `r` heard, those are all regex and it is
> better to mark that.
> 

Unintended mistake indeed. Good catch!

> ::: debug-viewer/GstDebugViewer/Main.py
> @@ +37,1 @@
>      from GstDebugViewer import version
> 
> We should use same versionning as GStreamer here fmpov :-)

Yeah that makes sense. I'll bump the version to current git.
Thanks for the reviews!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.