[Bug 793705] msdk: Implement Video Post Processing element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793705

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370877|none                        |reviewed
             status|                            |

--- Comment #39 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 370877:
 --> (https://bugzilla.gnome.org/review?bug=793705&attachment=370877)

::: sys/msdk/gstmsdkvpp.c
@@ +408,3 @@
     gst_object_unref (thiz->sinkpad_buffer_pool);
+    thiz->sinkpad_buffer_pool = gst_msdkvpp_create_buffer_pool (thiz,
+        GST_PAD_SINK, caps, min_buffers);

This code is not required. I mean, if downstream reject the pool, I imagine you
could delay the instantiation of sinkpad_buffer_pool until you really need,
avoid to have two pool dancing around.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.