[Bug 793705] msdk: Implement Video Post Processing element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793705

--- Comment #40 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #39)
> Review of attachment 370877 [details] [review]:
> 
> ::: sys/msdk/gstmsdkvpp.c
> @@ +408,3 @@
>      gst_object_unref (thiz->sinkpad_buffer_pool);
> +    thiz->sinkpad_buffer_pool = gst_msdkvpp_create_buffer_pool (thiz,
> +        GST_PAD_SINK, caps, min_buffers);
> 
> This code is not required. I mean, if downstream reject the pool, I imagine
> you could delay the instantiation of sinkpad_buffer_pool until you really
> need, avoid to have two pool dancing around.

Then we need to cache the allocation query caps and later, just before
performing the input buffer transformation, it has to create pool based this
caps. I would rather prefer to keep the current code which maintains an
internal pool which seems simpler to me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.