[Bug 795021] Reduce amount of memory allocations when payloading fixed-size audio buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795021

--- Comment #8 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Addressed review comments, apart from :

(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 370569 [details] [review]:
> @@ +133,3 @@
> +
> +  size = gst_buffer_get_sizes (buffer, &offset, NULL);
> +  gst_buffer_resize (buffer, offset * -1, size + offset);
> 
> This needs a comment, why the -1 :) We should probably also check here if
> the offset is as expected or that we can reset the buffer correctly?

I did add a comment, but the reset_buffer vmethod returns void, so I figured a
check was pretty much useless :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.