[Bug 795021] Reduce amount of memory allocations when payloading fixed-size audio buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795021

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371192|none                        |reviewed
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 371192:
 --> (https://bugzilla.gnome.org/review?bug=795021&attachment=371192)

::: gst-libs/gst/rtp/gstrtpbaseaudiopayload.c
@@ +160,3 @@
+    goto wrong_config;
+
+  self->size = size;

What if this size is bigger than our MTU here, or does not comply with the
min/max ptime?

@@ +188,3 @@
+
+static GstBufferPool *
+gst_rtp_buffer_pool_new (gsize size)

size is unused

@@ +1025,3 @@
+
+  if (!gst_buffer_pool_set_config (self->priv->pool, structure))
+    goto config_failed;

This is supposed to be done by the consumer of the pool

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.