[Bug 795021] Reduce amount of memory allocations when payloading fixed-size audio buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795021

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371193|none                        |reviewed
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 371193:
 --> (https://bugzilla.gnome.org/review?bug=795021&attachment=371193)

alawenc does not output fixed-size buffers, but depending on the input buffer
size, or not?

::: gst-libs/gst/audio/gstaudioencoder.c
@@ +2953,3 @@
+  if (enc->priv->ctx.pool) {
+    GstFlowReturn ret =
+        gst_buffer_pool_acquire_buffer (enc->priv->ctx.pool, &buffer, NULL);

Should probably sanity-check that size <= max_size here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.