[Bug 795139] Various patches on rtpsession

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795139

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370846|none                        |needs-work
             status|                            |

--- Comment #35 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 370846:
 --> (https://bugzilla.gnome.org/review?bug=795139&attachment=370846)

::: gst/rtpmanager/rtpsession.c
@@ +2699,3 @@
+    rtp_session_request_local_key_unit (sess, src, media_ssrc, FALSE,
+        current_time);
+  } else if (fci_length == 3 * sizeof (guint32)) {

Any reason to do this recv_xpli thing instead of auto-detecting if it's
Microsoft special or standard based on the packet itself?

::: gst/rtpmanager/rtpsource.h
@@ +209,3 @@
   GQueue        *retained_feedback;

+  RTPKeyUnitType key_unit_type;

This won't work.. you can currently request a mix of FIR and of PLI, so it you
can't pick a single type..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.