[Bug 795139] Various patches on rtpsession

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Apr 24 09:14:33 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795139

Mikhail Fludkov <fludkov.me at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fludkov.me at gmail.com

--- Comment #36 from Mikhail Fludkov <fludkov.me at gmail.com> ---
(In reply to Olivier CrĂȘte from comment #26)
> Review of attachment 370746 [details] [review]:
> 
> This is unsafe.. It only works if the array is already big enough.. it
> should try to grow it.
> 
> Instead, you can try to add a new API to GLib.. even though it will be a
> pain.. Maybe a hack is to add a int GValue copied from the stack, then reset
> it, then re-init it...

I agree. Actually, GLib has an API for it. g_value_array_append (arr, NULL)
allocates and zero fills the memory for the new value if needed, but does not
init it. I will update the patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list