[Bug 606643] isomp4: closed captions support (muxing and demuxing)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=606643

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367987|none                        |reviewed
             status|                            |

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 367987:
 --> (https://bugzilla.gnome.org/review?bug=606643&attachment=367987)

Just a question.

::: gst/isomp4/atoms.c
@@ +4019,3 @@
+  gmhd->tmcd = atom_tmcd_new ();
+  gmhd->tmcd->tcmi.text_size = 12;
+  gmhd->tmcd->tcmi.font_name = g_strdup ("Chicago");    /* Pascal string */

Could you pass these two as parameter to _new() ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.