[Bug 606643] isomp4: closed captions support (muxing and demuxing)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=606643

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367988|none                        |reviewed
             status|                            |

--- Comment #11 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 367988:
 --> (https://bugzilla.gnome.org/review?bug=606643&attachment=367988)

::: gst/isomp4/atoms.c
@@ +4061,3 @@
+
+  /* FIXME : Set the timescale to the same timescale as the video trak ! */
+  trak->mdia.mdhd.time_info.timescale = 30000;

Does this have any known side effects ? What would it take to carry the track
timescale ?

::: gst/isomp4/gstqtmux.c
@@ +884,3 @@
+
+  gst_buffer_map (newbuf, &map, GST_MAP_WRITE);
+  gst_buffer_map (buf, &inmap, GST_MAP_READ);

Shouldn't you check your return value ?

@@ +888,3 @@
+  GST_WRITE_UINT32_BE (map.data, map.size);
+  GST_WRITE_UINT32_LE (map.data + 4, FOURCC_cdat);
+  memcpy (map.data + 8, inmap.data, inmap.size);

Why not use gst_buffer_prepend_memory() ? (note I have no idea what size of
buffers we are talking about here)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.