[Bug 793513] rtpbin, jitterbuffer: ts-offset on RFC7273 synchronized streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793513

--- Comment #7 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 368718:
 --> (https://bugzilla.gnome.org/review?bug=793513&attachment=368718)

::: gst/rtpmanager/gstrtpjitterbuffer.c
@@ +1346,3 @@
   if ((item = rtp_jitter_buffer_peek (priv->jbuf))) {
     /* head buffer timestamp and offset gives our output time */
+    if (!rtp_jitter_buffer_is_rfc7273_synced (priv->jbuf))

Do you thin you could add a comment explaining why the offset is not apply in
RFC7273 mode? The Jitterbuffer code is already super hard to follow.

@@ +2056,3 @@
     return -1;

+  if (rtp_jitter_buffer_is_rfc7273_synced (priv->jbuf))

Same here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.