[Bug 793513] rtpbin, jitterbuffer: ts-offset on RFC7273 synchronized streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793513

Michael Tretter <m.tretter at pengutronix.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368718|0                           |1
        is obsolete|                            |

--- Comment #8 from Michael Tretter <m.tretter at pengutronix.de> ---
Created attachment 369086
  --> https://bugzilla.gnome.org/attachment.cgi?id=369086&action=edit
0001-rtpjitterbuffer-do-not-adjust-pts-if-streams-are-rfc.patch

(In reply to Olivier Crête from comment #7)
> Review of attachment 368718 [details] [review]:
> 
> ::: gst/rtpmanager/gstrtpjitterbuffer.c
> @@ +1346,3 @@
>    if ((item = rtp_jitter_buffer_peek (priv->jbuf))) {
>      /* head buffer timestamp and offset gives our output time */
> +    if (!rtp_jitter_buffer_is_rfc7273_synced (priv->jbuf))
> 
> Do you thin you could add a comment explaining why the offset is not apply
> in RFC7273 mode? The Jitterbuffer code is already super hard to follow.

I know:) I added comments in which I try to explain why the offset does not
apply. It's very hard to come up with a concise explanation, though.

> 
> @@ +2056,3 @@
>      return -1;
>  
> +  if (rtp_jitter_buffer_is_rfc7273_synced (priv->jbuf))
> 
> Same here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.