[Bug 792378] qmlglsink: make work with eglfs_kms

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Feb 26 12:31:23 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=792378

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368851|none                        |reviewed
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 368851:
 --> (https://bugzilla.gnome.org/review?bug=792378&attachment=368851)

::: ext/qt/gstqtglutility.cc
@@ +43,3 @@
+#include <gst/gl/egl/gstegl.h>
+#include <gst/gl/egl/gstgldisplay_egl.h>
+#include <qpa/qplatformnativeinterface.h>

This probably needs a new configure check, meson check?

@@ +124,3 @@
+        QGuiApplication::platformNativeInterface();
+    EGLDisplay egl_display = (EGLDisplay)
+        native->nativeResourceForWindow("egldisplay", NULL);

I'm wondering if this code shouldn't also be used for the #else (generic EGL)
case below instead of randomly selecting 0 as EGL display.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list