[Bug 792378] qmlglsink: make work with eglfs_kms

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792378

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368851|reviewed                    |needs-work
             status|                            |

--- Comment #9 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 368851:
 --> (https://bugzilla.gnome.org/review?bug=792378&attachment=368851)

::: ext/qt/gstqtglutility.cc
@@ +43,3 @@
+#include <gst/gl/egl/gstegl.h>
+#include <gst/gl/egl/gstgldisplay_egl.h>
+#include <qpa/qplatformnativeinterface.h>

There's no meson definition for qml plugins yet.  configure check for
qpa/qplatformnativeinterface.h already exists however need to be explicitly
checked in the GBM case in order to enable GBM in qmlglsink.  Same for the
viv-fb case actually.

@@ +120,3 @@
+     * display. (It must be a non-NULL struct gbm_device * pointer.) So we
have
+     * no choice but to use the native interface to get the EGLDisplay.
+     */

Remove "We actually use the code mentioned above in the comments," It's
confusing :)

Just state what we need to do for GBM.

@@ +124,3 @@
+        QGuiApplication::platformNativeInterface();
+    EGLDisplay egl_display = (EGLDisplay)
+        native->nativeResourceForWindow("egldisplay", NULL);

0 is the 'any display' value defined in the egl headers so is not 'random'

As for whether this should be used for generic EGL, probably. The main other
use case for that is android where there is only ever one EGLDisplay.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.