[Bug 793820] Implement paste functionality within GESTimeline class

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Feb 26 22:03:58 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793820

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368980|none                        |needs-work
             status|                            |

--- Comment #9 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 368980:
 --> (https://bugzilla.gnome.org/review?bug=793820&attachment=368980)

It is almost good and I am being a bit annoying but let's get it **right** ;)

::: ges/ges-timeline-element.c
@@ +1863,3 @@
+ges_timeline_element_get_copied_from (GESTimelineElement * self)
+{
+  GESTimelineElement * copied_from_ref =
gst_object_ref(self->priv->copied_from);

I am pretty much sure it is not `gst-indent` complient, could you check that
please?

You could have done:

```
copied_from = self->priv->copied_from;
self->priv->copied_from = NULL;
return copied_from;
```

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list