[Bug 793820] Implement paste functionality within GESTimeline class

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793820

--- Comment #10 from Alex Băluț <alexandru.balut at gmail.com> ---
Review of attachment 368980:
 --> (https://bugzilla.gnome.org/review?bug=793820&attachment=368980)

::: ges/ges-timeline.c
@@ +3743,3 @@
+ * Paste @element inside the timeline. @element must have been
+ * created using ges_timeline_element_copy with recurse=TRUE set,
+ * @paste_position: The position in the timeline the element should

How "it will fail"? Describe instead exactly what happens.

It's too bad you can't paste an object you created yourself.. which are not
copied.

@@ +3745,3 @@
+ * otherwise it will fail.
+ *
+ * be pasted to, meaning it will become the start of @element

Is this better? "The @element copy which has been pasted"

@@ +3761,3 @@
+
+  if (!copied_from) {
+ * Returns: (transfer none): Paste @element copying the element

*has not been copied recursively

@@ +3767,3 @@
+
+  if (!element_class->paste) {
+ges_timeline_paste_element (GESTimeline * timeline, GESTimelineElement *
element,

Should we print element or element_class?

::: ges/ges-timeline.h
@@ +161,3 @@
+GST_EXPORT
+GESTimelineElement * ges_timeline_paste_element (GESTimeline * timeline,
+  GESTimelineElement * element, GstClockTime paste_position, gint
layer_priority);

Why "paste_position" and not "position"?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.