[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768248

--- Comment #88 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
I see this in valgrind (and more):

==421== Invalid write of size 2
==421==    at 0x360DEAD7: gst_vaapi_encoder_ensure_param_roi_regions
(gstvaapiencoder.c:341)
==421==    by 0x360E8DC2: ensure_misc_params (gstvaapiencoder_h264.c:2540)
==421==    by 0x360E8DC2: gst_vaapi_encoder_h264_encode
(gstvaapiencoder_h264.c:2867)
==421==    by 0x360DED40: gst_vaapi_encoder_put_frame (gstvaapiencoder.c:512)
==421==    by 0x360B3EB9: gst_vaapiencode_handle_frame (gstvaapiencode.c:691)
==421==    by 0xF856F8E: gst_video_encoder_chain (gstvideoencoder.c:1548)
==421==    by 0x4EBA69A: gst_pad_chain_data_unchecked (gstpad.c:4275)
==421==    by 0x4EBA69A: gst_pad_push_data (gstpad.c:4531)
==421==    by 0x4EC2802: gst_pad_push (gstpad.c:4650)
==421==    by 0xF5EDA1F: gst_base_transform_chain (gstbasetransform.c:2321)
==421==    by 0x4EBA69A: gst_pad_chain_data_unchecked (gstpad.c:4275)
==421==    by 0x4EBA69A: gst_pad_push_data (gstpad.c:4531)
==421==    by 0x4EC2802: gst_pad_push (gstpad.c:4650)
==421==    by 0xF5EDA1F: gst_base_transform_chain (gstbasetransform.c:2321)
==421==    by 0x4EBA69A: gst_pad_chain_data_unchecked (gstpad.c:4275)
==421==    by 0x4EBA69A: gst_pad_push_data (gstpad.c:4531)
==421==  Address 0xedc2768 is 168 bytes inside an unallocated block of size
1,072 in arena "client"

Which leads to this (probably just a side effect):
==421== Invalid read of size 2
==421==    at 0x389A3ECA: intel_encoder_check_roi_parameter
(i965_encoder.c:671)
==421==    by 0x389A3ECA: intel_encoder_check_brc_parameter
(i965_encoder.c:726)
==421==    by 0x389A3ECA: intel_encoder_check_misc_parameter
(i965_encoder.c:861)
==421==    by 0x389A3ECA: intel_encoder_sanity_check_input
(i965_encoder.c:1335)
==421==    by 0x389A3ECA: intel_encoder_end_picture (i965_encoder.c:1351)
==421==    by 0x3634B28F: vaEndPicture (va.c:1316)
==421==    by 0x360EE4AF: gst_vaapi_enc_picture_encode
(gstvaapiencoder_objects.c:590)
==421==    by 0x360E926C: gst_vaapi_encoder_h264_encode
(gstvaapiencoder_h264.c:2873)
==421==    by 0x360DED40: gst_vaapi_encoder_put_frame (gstvaapiencoder.c:512)
==421==    by 0x360B3EB9: gst_vaapiencode_handle_frame (gstvaapiencode.c:691)
==421==    by 0xF856F8E: gst_video_encoder_chain (gstvideoencoder.c:1548)
==421==    by 0x4EBA69A: gst_pad_chain_data_unchecked (gstpad.c:4275)
==421==    by 0x4EBA69A: gst_pad_push_data (gstpad.c:4531)
==421==    by 0x4EC2802: gst_pad_push (gstpad.c:4650)
==421==    by 0xF5EDA1F: gst_base_transform_chain (gstbasetransform.c:2321)
==421==    by 0x4EBA69A: gst_pad_chain_data_unchecked (gstpad.c:4275)
==421==    by 0x4EBA69A: gst_pad_push_data (gstpad.c:4531)
==421==    by 0x4EC2802: gst_pad_push (gstpad.c:4650)
==421==  Address 0xedc2768 is 24 bytes after a block of size 32 in arena
"client"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.