[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768248

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #369066|none                        |needs-work
             status|                            |

--- Comment #89 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 369066:
 --> (https://bugzilla.gnome.org/review?bug=768248&attachment=369066)

Found what cause the crashes.

::: gst-libs/gst/vaapi/gstvaapiencoder.c
@@ +311,3 @@
+
+  region_roi = (VAEncROI *) misc->param + sizeof (VAEncMiscParameterBuffer) +
+      sizeof (VAEncMiscParameterBufferROI);

Should be:
  region_roi = (VAEncROI *) ((guint8*) misc->param + sizeof
(VAEncMiscParameterBuffer) +
      sizeof (VAEncMiscParameterBufferROI));

Otherwise you are adding VAEncROI instead of bytes. There use to be a guchar*
cast in the old code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.