[Bug 793441] rtsp-stream: client transport is not updated for multicast clients

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 28 08:29:17 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793441

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #369080|none                        |reviewed
             status|                            |

--- Comment #23 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 369080:
 --> (https://bugzilla.gnome.org/review?bug=793441&attachment=369080)

::: gst/rtsp-server/rtsp-client.c
@@ -1883,3 @@
-         * the one requested by the client */
-        addr = gst_rtsp_stream_reserve_address (ctx->stream, ct->destination,
-            ct->port.min, ct->port.max - ct->port.min + 1, ct->ttl);

If use_client_settings is TRUE, shouldn't we make sure to reserve the address
that the (new) client wants instead of just doing nothing? How can we otherwise
be sure that we can later use it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list