[Bug 793441] rtsp-stream: client transport is not updated for multicast clients

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 28 08:34:25 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793441

--- Comment #24 from Patricia Muscalu <patricia at axis.com> ---
(In reply to Sebastian Dröge (slomo) from comment #23)
> Review of attachment 369080 [details] [review]:
> 
> ::: gst/rtsp-server/rtsp-client.c
> @@ -1883,3 @@
> -         * the one requested by the client */
> -        addr = gst_rtsp_stream_reserve_address (ctx->stream,
> ct->destination,
> -            ct->port.min, ct->port.max - ct->port.min + 1, ct->ttl);
> 
> If use_client_settings is TRUE, shouldn't we make sure to reserve the
> address that the (new) client wants instead of just doing nothing? How can
> we otherwise be sure that we can later use it?

It's not the multicast address we want to reserve. What we want to to here is
to reserve a unicast address that the socket is bound to. There is a FIXME in
gst_rtsp_stream_reserve_address().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list