[Bug 792167] omxvideoenc: early return in fill_buffer() if something goes wrong

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jan 3 15:12:24 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=792167

--- Comment #1 from Guillaume Desmottes <gdesmott at gnome.org> ---
Created attachment 366245
  --> https://bugzilla.gnome.org/attachment.cgi?id=366245&action=edit
omxvideoenc: early return in fill_buffer() if something goes wrong

If something goes wrong while trying to manually copy the input buffer,
the 'break' was moving us out of the 'for' loop but not out of the switch
block.
So we ended up calling gst_video_frame_unmap() a second time (raising
assertions) and returning TRUE rather than FALSE.

Reproduced with a WIP zynqultrascaleplus OMX branch reporting wrong
buffer sizes and so triggering this bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list