[Bug 792167] omxvideoenc: early return in fill_buffer() if something goes wrong

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792167

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.13.1

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
commit 5fa96cab7bf92d6840ab1c69824a94009acec2fc
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Wed Jan 3 16:07:18 2018 +0100

    omxvideoenc: early return in fill_buffer() if something goes wrong

    If something goes wrong while trying to manually copy the input buffer,
    the 'break' was moving us out of the 'for' loop but not out of the switch
block.
    So we ended up calling gst_video_frame_unmap() a second time (raising
    assertions) and returning TRUE rather than FALSE.

    Reproduced with a WIP zynqultrascaleplus OMX branch reporting wrong
    buffer sizes and so triggering this bug.

    https://bugzilla.gnome.org/show_bug.cgi?id=792167

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.