[Bug 792695] rtpbuffer: Add new RTPBuffer flags for FEC

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792695

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367097|none                        |reviewed
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 367097
  --> https://bugzilla.gnome.org/attachment.cgi?id=367097
rtpbuffer.h: Add new RTPBuffer flags

+1 Looks good to me, apart from these nitpicks:

>+ * @GST_RTP_BUFFER_FLAG_REDUNDANT:      The packet represents redundant RTP packet.
>+ *           The flag is used in gstrtpstorage to be able to hold the packetback
>+ *           and use it only for recovery from packet loss.
>+ * @GST_RTP_BUFFER_FLAG_IMPORTANT:      The packet is essential for correct
>+ *           decoding of the stream, and should for example be protected as well
>+ *           as possible when performing Forward Error Correction (FEC)
>+ * @GST_RTP_BUFFER_FLAG_IGNORABLE:  The packet is not essential for correct
>+ *           decoding of the stream, and can for example be safely ignored by FEC
>+ *           mechanisms.

Please add a "(Since: 1.14)" at the end of each of the descriptions for the new
enums. 

> typedef enum {
>   GST_RTP_BUFFER_FLAG_RETRANSMISSION = (GST_BUFFER_FLAG_LAST << 0),
>+  GST_RTP_BUFFER_FLAG_REDUNDANT      = (GST_BUFFER_FLAG_LAST << 1),
>+  GST_RTP_BUFFER_FLAG_IMPORTANT  = (GST_BUFFER_FLAG_LAST << 2),
>+  GST_RTP_BUFFER_FLAG_IGNORABLE  = (GST_BUFFER_FLAG_LAST << 3),
>   GST_RTP_BUFFER_FLAG_LAST           = (GST_BUFFER_FLAG_LAST << 8)
> } GstRTPBufferFlags;

Could we align the '=' here with the others? :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.