[Bug 792695] rtpbuffer: Add new RTPBuffer flags for FEC

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792695

--- Comment #3 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 367097:
 --> (https://bugzilla.gnome.org/review?bug=792695&attachment=367097)

The IGNORABLE & IMPORTANT flags don't seem specific to RTP at all. I wonder if
we should instead put them in GstBufferFlags. This way, the encoder or parser
can mark the buffers directly if possible. Are you implemented ulpfec? In that
case, you may also want to only mark a part of a buffer as important and we'd
probably need a new Meta for this.. So maybe this should be a Meta instead ?

::: gst-libs/gst/rtp/gstrtpbuffer.h
@@ +241,3 @@
+ * @GST_RTP_BUFFER_FLAG_IGNORABLE:  The packet is not essential for correct
+ *           decoding of the stream, and can for example be safely ignored by
FEC
+ *           mechanisms.

Isn't this the same as GST_BUFFER_FLAG_DROPPABLE ? It seems like a duplicate

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.