[Bug 792695] rtpbuffer: Add new RTPBuffer flags for FEC

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jan 22 19:33:15 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=792695

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Good call re. core buffer flags, that could indeed go there instead.

Bug #685279 also needs addition of some kind of IMPORTANT/DO_NOT_DROP buffer
flag to make sure still video frames in DVD menus aren't accidentally dropped
because of QoS.

I remember the 'mark part of a buffer as important (or more important)' thing
in ulpfec coming up in discussions. I believe it was said that no one was using
that yet, so it seems premature to add anything for it now.

I think we can go a long way with the two proposed buffer flags, and I think we
should only add a full-fledged meta once we have a clearer idea what exactly is
needed and we have something using it. Premature featurisation being the root
of all evil etc.

Also, Metas are much heavier than flags (1-N allocs/frees), so it would be
really good to avoid them, especially for things like RTP buffers, unless
absolutely needed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list