[Bug 792825] rtph264pay: add support for STAP-A bundling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792825

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367317|none                        |needs-work
             status|                            |

--- Comment #2 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 367317:
 --> (https://bugzilla.gnome.org/review?bug=792825&attachment=367317)

I really like the idea of this patchset and I wanted to have this for years!

::: gst/rtp/gstrtph264pay.c
@@ +71,3 @@
 #define DEFAULT_SPROP_PARAMETER_SETS    NULL
 #define DEFAULT_CONFIG_INTERVAL              0
+#define DEFAULT_DO_AGGREGATE        FALSE

I think this should default to TRUE as I think it's almost always the best
behaviour. My only worry is that it will break interop with lesser RTP stacks.

@@ -990,0 +1039,53 @@
+
+static void
+gst_rtp_h264_reset_bundle (GstRtpH264Pay * rtph264pay)
... 50 more ...

Don't leave code between "#if 0", you can use GST_CAT_MEMDUMP() or if
(gst_debug_category_get_threshold (GST_CAT_DEFAULT) > GST_LEVLE_MEMDUMP) { and
then print top the memdump level using the macros).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.