[Bug 792361] omxvideoenc: implement dmabuf import on zynqultrascaleplus

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792361

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #366917|none                        |needs-work
             status|                            |

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 366917:
 --> (https://bugzilla.gnome.org/review?bug=792361&attachment=366917)

I can clearly see that this implementation has the limitation that only 1 FD is
allowed, but I don't see any checks/validatation for this. Also, remember that
you could have multiple memory FD, but with the same FD repeated.

::: omx/gstomxvideoenc.c
@@ +1248,3 @@
+    } else {
+      GST_DEBUG_OBJECT (self,
+          "Input is dmabuf but misaligned, don't use dmabuf import");

This trace sounds weird, misaligned ? Why not wrong allocation mode or
something ? Alignment is checked later.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.