[Bug 792361] omxvideoenc: implement dmabuf import on zynqultrascaleplus

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792361

--- Comment #5 from Guillaume Desmottes <gdesmott at gnome.org> ---
(In reply to Nicolas Dufresne (stormer) from comment #4)
> Review of attachment 366917 [details] [review]:
> 
> I can clearly see that this implementation has the limitation that only 1 FD
> is allowed, but I don't see any checks/validatation for this. 

This is already checked in can_use_dynamic_buffer_mode(). If input buffer has
more than one memory then we don't use dynamic allocation mode and so won't use
dmabuf import either.

> ::: omx/gstomxvideoenc.c
> @@ +1248,3 @@
> +    } else {
> +      GST_DEBUG_OBJECT (self,
> +          "Input is dmabuf but misaligned, don't use dmabuf import");
> 
> This trace sounds weird, misaligned ? Why not wrong allocation mode or
> something ? Alignment is checked later.

changed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.