[Bug 795891] matroskademux: emits invalid Pango markup

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795891

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372896|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 372896:
 --> (https://bugzilla.gnome.org/review?bug=795891&attachment=372896)

Generally looks good to me

::: gst-libs/gst/pbutils/markup-utils.c
@@ +1,2 @@
+/* GStreamer base utils library text markup utility functions
+ * Copyright (C) 2018 Philippe Normand <philn at igalia.com>

Isn't this based on the code from subparse? :)

@@ +70,3 @@
+  }
+
+  tag_regex = g_regex_new (search_pattern, 0, 0, NULL);

Yes please store the regex in some kind of GOnce :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.