[Bug 795891] matroskademux: emits invalid Pango markup

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795891

--- Comment #15 from Philippe Normand <philn at igalia.com> ---
(In reply to Tim-Philipp Müller from comment #12)
> Comment on attachment 372896 [details] [review]
> 0001-pbutils-Add-markup-utils-module.patch
> 
> >+++ b/gst-libs/gst/pbutils/markup-utils.c
> >+/* GStreamer base utils library text markup utility functions
> >+ * Copyright (C) 2018 Philippe Normand <philn at igalia.com>
> 
> Haven't looked at the patch properly yet, was just wondering if this code
> was all yours originally? :)

Ah sorry about this, of course I didn't write all this, it comes from subparse.
I'll git blame it and mention original authors.

(In reply to Sebastian Dröge (slomo) from comment #13)
> Review of attachment 372898 [details] [review]:
> 
> ::: gst/matroska/matroska-demux.c
> @@ +2315,3 @@
> +  keyunit = !!(flags & GST_SEEK_FLAG_KEY_UNIT);
> +  after = !!(flags & GST_SEEK_FLAG_SNAP_AFTER);
> +  before = !!(flags & GST_SEEK_FLAG_SNAP_BEFORE);
> 
> Irrelevant changes, please put into a separate commit (just push it, no need
> for review) :)
> 

Ok :)

> @@ +3400,3 @@
>        utf8 = g_markup_escape_text ((gchar *) map.data, map.size);
>  
> +      /* FIXME: WebVTT support */
> 
> What does this mean? Will WebVTT work correctly but it is just not sanitized?

Well, Matroska seems to have WebVTT support in addition to SRT and other
formats already supported by the demuxer. But currently WebVTT isn't supported
by the demuxer, afaics.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.