[Bug 796832] New: vaapih264dec: Does not always recover from data lost

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796832

            Bug ID: 796832
           Summary: vaapih264dec: Does not always recover from data lost
    Classification: Platform
           Product: GStreamer
           Version: unspecified
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer-vaapi
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: nicolas at ndufresne.ca
        QA Contact: gstreamer-bugs at lists.freedesktop.org
                CC: bsreerenj at gmail.com, vjaquez at igalia.com
     GNOME version: ---

I have hit some case were we have data lost and corruption which would
lead to a slice decode error (slices from two frames got mixed up I think).
the problem is that the decoder just never recover from this bad state. In
the situation, the DPB get's propulated with a bad frame and I believe this
causes the following decodes to fail. And then we are stuck in that state
forever.

When this case was reached, we'd first get the error:
  "found no short-term reference picture with PicNum ..."

I notice that in this case, we send to the accelerator a broken (or even
empty) reference list. This seems like a bad idea, it also puts a lot of
pressure on the accelerator to do the right thing. So the following patch
simply chain up that error and fails the affected slice decoding. And that
allows the decoder to recover from this error. I'll try and extract a sample
to reproduce this soon. The stream is interlaced.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.