[Bug 796832] vaapih264dec: Does not always recover from data lost

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jul 19 09:24:10 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796832

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373088|none                        |reviewed
             status|                            |

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 373088:
 --> (https://bugzilla.gnome.org/review?bug=796832&attachment=373088)

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +4482,3 @@
     if (priv->stream_alignment == GST_VAAPI_STREAM_ALIGN_H264_NALU) {
       buf_size = size;
+      if (size > 4)

I guess the patch would be simpler if, above, in line 4479 we change

-    if (size < 4)
+    if (size =< 4) 
       return GST_VAAPI_DECODER_STATUS_ERROR_NO_DATA

which works for both stream alignments

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list