[Bug 796875] rtsp-client: always allocate both IPV4 and IPV6 sockets

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796875

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373192|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373192:
 --> (https://bugzilla.gnome.org/review?bug=796875&attachment=373192)

::: gst/rtsp-server/rtsp-client.c
@@ +1880,3 @@
+
+    if (!gst_rtsp_stream_allocate_udp_sockets (ctx->stream,
G_SOCKET_FAMILY_IPV6, ct,
+            use_client_settings) && family == G_SOCKET_FAMILY_IPV6)

This still fails if allocating one of the two ports fails in the case where the
pool only contains one kind of addresses. That seems wrong

Also you still have the problem you're fixing here with multicast now as
currently there is only one multicast sink. You at least have to add one for
both families.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.