[Bug 796875] rtsp-client: always allocate both IPV4 and IPV6 sockets

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796875

--- Comment #6 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #5)
> Review of attachment 373192 [details] [review]:
> 
> ::: gst/rtsp-server/rtsp-client.c
> @@ +1880,3 @@
> +
> +    if (!gst_rtsp_stream_allocate_udp_sockets (ctx->stream,
> G_SOCKET_FAMILY_IPV6, ct,
> +            use_client_settings) && family == G_SOCKET_FAMILY_IPV6)
> 
> This still fails if allocating one of the two ports fails in the case where
> the pool only contains one kind of addresses. That seems wrong
> 

This fails configuring the client transport if we couldn't set it up for the
requested family, but that is the current behaviour too, are you saying the
current behaviour is wrong wrt that as well?

> Also you still have the problem you're fixing here with multicast now as
> currently there is only one multicast sink. You at least have to add one for
> both families.

I'm not sure I get what you mean, for udp the udp sinks can have both IPV6 and
IPV4 , it simply needs to be done before the sinks are started, are you saying
this is not the case for multicast?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.